feat: digest-only calendars that never distribute blockers#15
Merged
Conversation
digest_calendars を Account に追加し、ダイジェストのライブ取得にだけ参加する 通知専用カレンダーを指定できるようにする(google のみ・calendars との重複や リスト内重複・空文字列はエラー)。collectDigest のカレンダーループを Calendars→DigestCalendars の連結にするだけで、tick/reconcile 等の同期エンジンは 無変更(digest_calendars は監視対象に含まれないため構造的にブロッカー配布対象 にならない)。
There was a problem hiding this comment.
Pull request overview
Adds a third calendar role, digest_calendars, to support “digest-only” calendars that appear in the morning digest but never participate in the sync engine (cursor/cache/reconcile/blocker distribution), aligning with calsync’s engine invariants by keeping these calendars structurally out of tick.
Changes:
- Extend config schema with
accounts[].digest_calendars(Google only) plus validation (no overlap withcalendars, no duplicates, no empty entries; Microsoft rejected due to v1 constraint). - Include
DigestCalendarsin digest live-collection (collectDigest) while keepingtickdistribution unaffected; add regression tests to lock this in. - Document the feature in README and CHANGELOG; add a dedicated design spec.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| README.md | Documents digest_calendars, its constraints, and how to find a Google Calendar ID. |
| internal/engine/notify.go | Includes DigestCalendars in digest live fetch by concatenating with Calendars. |
| internal/engine/notify_test.go | Adds tests ensuring digest inclusion and preventing blocker distribution from digest_calendars. |
| internal/config/config.go | Adds DigestCalendars to config model, YAML loading, and validation (Google-only; dedupe/empty/overlap checks). |
| internal/config/config_test.go | Adds config-load tests covering acceptance/rejection and validation errors for digest_calendars. |
| docs/superpowers/specs/2026-07-06-digest-calendars-design.md | New design spec describing intent, constraints, validation, and test plan. |
| CHANGELOG.md | Records the new digest_calendars feature under Added. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+16
to
+21
| accounts: | ||
| - id: personal | ||
| provider: google | ||
| email: okash1n.fcs@gmail.com | ||
| digest_calendars: ["xxxxx@group.calendar.google.com"] # 通知専用(ブロック元にならない) | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
「他アカウントへブロッカーを配布したくないが、朝のダイジェストには載せたい」カレンダー(例: ゴミの日カレンダー)のための第 3 の役割
digest_calendarsを追加します。実装ポイント
calendarsに含まれないため — tick がDigestCalendarsを一切読まないことを回帰テストTestTickNeverDistributesDigestCalendarEventsで固定)calendarsとの重複・リスト内重複・空文字列はエラー検証
go build/go test ./... -race -count=1/go vet/gofmt -l(出力なし)/docker compose config -q✅